docs(jupyterhub): sync template standards updates#356
Open
mberlofa wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughAdds two new NetworkPolicy extraEgress fields (CIDR and port) to the jupyterhub playground configuration, adds jupyterhub to the site-synced playground chart allowlist, and reformats the jupyterhub docs Values table for column alignment. ChangesJupyterHub playground egress support
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - Keep the JupyterHub Helm test hook under `templates/tests/` so `helm test` renders and executes it, with unittest coverage restored. - Add `networkPolicy.extraEgress` as an additive Hub egress alias while preserving `networkPolicy.hub.egress`. - Rewrite NOTES into numbered operational sections and update README/schema/unit coverage. ## Related - Site sync: helmforgedev/site#356. - Closes part of #633. ## Validation - `helm template test charts/jupyterhub | rg -n "helm.sh/hook|test-connection"` (hook rendered from `templates/tests/test-connection.yaml`) - `helm unittest charts/jupyterhub` (69 tests, 9 suites) - `make template-standards-check CHART=jupyterhub` - `node scripts/charts/validate-chart.js --chart jupyterhub --no-k3d` - `make validate-chart CHART=jupyterhub TIMEOUT=900` (FULLY VALIDATED, 19 layers) - `make release-check REPO=charts` - `make attribution-check REPO=charts` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added support for `networkPolicy.hub.extraEgress` to append additional Hub egress rules while keeping the default egress behavior. * **Bug Fixes** * Updated generated NetworkPolicy output to include the additional egress rules in the rendered `spec.egress`. * **Documentation** * Refreshed chart documentation and generated notes to describe the new extra egress setting. * **Tests** * Extended the NetworkPolicy test coverage to verify the appended egress rule is generated as expected. * **Chores** * Improved NetworkPolicy value validation by defining the new `extraEgress` structure. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
networkPolicy.extraEgressin the JupyterHub playground controlsValidation
npm run lintnpm run format:checknpm run buildmake site-sync-check CHART=jupyterhubRelated charts PR: helmforgedev/charts#678
Summary by CodeRabbit
New Features
Documentation